Gitlab-ce 8 log rotation not

We recently upgraded to Omnibus gitlab-ce-8.12.3-ce.0.el6.x86_64 on Centos 6 but it seems log rotation stops working.

gitlab-ctl status
run: gitlab-workhorse: (pid 15639) 431175s; run: log: (pid 781) 990494s
run: logrotate: (pid 1456) 2041s; run: log: (pid 12217) 250609s
run: nginx: (pid 15814) 431174s; run: log: (pid 782) 990494s
run: postgresql: (pid 15903) 431173s; run: log: (pid 779) 990494s
run: redis: (pid 16029) 431173s; run: log: (pid 788) 990494s
run: sidekiq: (pid 21530) 34201s; run: log: (pid 780) 990494s
run: unicorn: (pid 17075) 431167s; run: log: (pid 792) 990494s

Here is from /etc/gitlab/gitlab.rb

logging[‘logrotate_frequency’] = “daily” # rotate logs daily
logging[‘logrotate_size’] = nil # do not rotate by size by default
logging[‘logrotate_rotate’] = 10 # keep 30 rotated logs
logging[‘logrotate_compress’] = “compress” # see ‘man logrotate’
logging[‘logrotate_method’] = “copytruncate” # see ‘man logrotate’
logging[‘logrotate_postrotate’] = nil # no postrotate command by default

logrotate[‘enable’] = true

gitlab-ctl reconfigure
gitlab-ctl restart logrotate

But the logs are not rotating, eg: /var/log/gitlab/gitlab-rails/production.log keeps growing. Any ideas?