Proper packagecloud puppet configuration

I am trying to install Gitlab Runners using the Puppet configuration suggested by https://packages.gitlab.com/runner/gitlab-runner/install#puppet

It says to include

packagecloud::repo { "runner/gitlab-runner":
  type => 'rpm',  # or "deb" or "gem"
  server_address => 'https://packages.gitlab.com/',
}

Using this puppet code creates Yum configuration with extra slashes:

# This file is managed by puppet
# module 'packagecloud'

[runner_gitlab-runner]
name=runner_gitlab-runner
baseurl=https://packages.gitlab.com//runner/gitlab-runner/el/7/x86_64/
repo_gpgcheck=1
gpgcheck=0
enabled=1
gpgkey=https://packages.gitlab.com//runner/gitlab-runner/gpgkey
sslverify=1
sslcacert=/etc/pki/tls/certs/ca-bundle.crt
metadata_expire=300

Will these extra slashes potentially cause a problem?

Is this a misconfiguration by Gitlab, a bug in the PackageCloud Puppet Module, or an issue with my Puppet configuration?

Hi,

it seems that this is a feature of Packagecloud, the underlaying infrastructure where GitLab packages are provided from. To me, this documentation seems generated all-in-one.

I just had been looking into its repository, last commit 2017. Unfortunately fairly old. Though the additional slashes shouldn’t cause any harm. In case you are not sure about it, just spin up a test VM in your staging environment :slight_smile:

I would also recommend a community maintained Puppet module to install GitLab and the runners, namely by Voxpupuli. Or you’ll go with using the yumrepo resource type which also works nicely.

Cheers,
Michael

Thanks Michael.

I use the Voxpupuli module for my Gitlab servers. Last time I looked at the CI Runner module, it didn’t meet our needs and we started writing our own. I will look at it again.