Reading unsupported config value smtp when configuring external SMTP

I’m following and copied pasted the configuration blocks replacing emails and password as appropriate and not quoting anything not already in quotes.

However reconfigure always fails with

Reading unsupported config value smtp.

Are the docs outdated? I put this block at the very end of the file /etc/gitlab/gitlab.rb

Leaving SMTP settings to default doesn’t work either, and I know postfix is configured correctly

Okay issue solved.

It seems

gitlab_rails['smtp_enable_starttls_auto'] = true

Should be

gitlab_rails['smtp_enable_starttls'] = true

The docs are incorrect