Autodevops code_quality seems to run properly but I see no report, and always have "No changes to code quality" in MRs

youri_b · February 18, 2020, 2:55pm

I created a template Java project (using the built-in “Spring” template), configured with AutoDevOps.
I’m evaluating Gitlab CI, using the trial period of gitlab.com (on shared runners).

The code_quality job seems to work fine, and ends up with :

Uploading artifacts...
gl-code-quality-report.json: found 1 matching files 
Uploading artifacts to coordinator... ok            id=441518751 responseStatus=201 Created token=XRnGz_Xv
Job succeeded

But there is no artifact visible in the job :

If I create a MR with many code mistakes, it always says there is “No changes to code quality”.

I did not add any .gitlab-ci.yml : only using the autodevops feature, that detects it’s a Maven project (through mvnw file), and successfully compiles and runs unit tests on it.

I have the same behavior on another (custom) Maven project.

I also see that license_management, sast and dast jobs fail. Are there issues with current autodevops configuration?

jheimbuck_gl · February 24, 2020, 4:16pm

Hi @youri_b, Product Manager for the testing team here. If your Merge Request does not introduce changes to the code quality, improvements or degradations, the widget on the Merge Request page will show that no change occurred as you are seeing. If you are interested in the issues in the code you can download the full report from the jobs page. We are working on an issue to display the full code quality report content on that page as well and hope to release that soon.

youri_b · February 24, 2020, 4:43pm

@jheimbuck_gl thanks for your answer

But I did introduce bad Java code in this MR (see my post above) : System.out.println, catching all exceptions without doing anything etc. See snapshot below :

I’d be surprised the quality control of gitlab does not catch this.

In the jobs page, there is no download icon for the quality tests :

So it behaves as if no control has been done.

Thanks for the link about displaying the quality report in the gitlab UI. I see this should be available soon, which would be important to us, too. Unfortunately, in my case, I suppose it would not display anything for now.

jheimbuck_gl · February 24, 2020, 9:47pm

@youri_b - This consumes the code climate open source engine, you may find more information about what is detected/let through in their docs.

The download button appears if you have setup an artifacts:paths keyword in the gitlab-ci.yml. You’ll find more info in the documentation.

The full code quality report will show the full contents of the report on the pipeline page, not just the changes as the Merge Request widget does so if your code includes detected issues they will display.

Hopefully this helps!

youri_b · February 25, 2020, 1:29pm

@jheimbuck_gl, thanks : it helped.

As stated in my original post, I did not create any .gitlab-ci.yml : I rely on the autodevops feature without any customization.

I created a new MR adding a method with a lot of arguments and it has indeed been detected by the code quality tests.

So it’s running, even if I still don’t have any download icon on the code-quality jobs :

But I’m very disappointed by the accuracy of these quality tests, as they did not detect what I consider as classical Java anti-patterns. Compared to SonarQube, it seems to be night and day (at least on Java language)

jheimbuck_gl · February 25, 2020, 3:42pm

@youri_b - It looks like the default engine setup from CodeClimate isn’t the best for your project and I see what you mean now about the downloadable artifact. I was looking at the job page, not pipelines page. Sorry about that confusion.

There is a SonarJava plugin available and inclusion of the plugin in a .codeclimate.yml may override the defaults from the AutoDevops but I have not tried that so cannot confirm. If you give it a go let us know how it goes!