Upgrade from 8.0 to 8.8 failed

Hi

I tried upgrading our Gitlab instance and I’m stuck with an error:

== 20160204144558 AddRealSizeToMergeRequestDiffs: migrating ===================
– add_column(:merge_request_diffs, :real_size, :string)rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Invalid port number: “crm”/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:1283:in `port=’

How to paste logfiles here?

== 20160204144558 AddRealSizeToMergeRequestDiffs: migrating ===================
– add_column(:merge_request_diffs, :real_size, :string)rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Invalid port number: "crm"/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:1283:in `port='
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:803:in `block in initialize'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:2248:in `call'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:2248:in `defer_validation'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:795:in `initialize'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:138:in `new'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:138:in `parse'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/url_sanitizer.rb:10:in `initialize'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:27:in `new'
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:27:in `block in process_proj

ects_with_wrong_url’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in block in each' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in each’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in each' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:25:in process_projects_with
wrong_url’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:16:in block in up' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:63:in block (2 levels) in i
n_transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb
:211:in transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/transactions.rb:220:in transaction’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:62:in block in in_transacti on' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in block in say_with_time’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in say_with_time' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:61:in in_transaction’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:16:in up' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:611:in exec_migration’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:592:in block (2 levels) in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:591:in block in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:292
:in with_connection' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:590:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:768:in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:998:in block in execute_migration_in

transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:1044:in block in ddl_transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb :213:in block in transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/transaction.rb:184:in
within_new_transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb :213:in transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/transactions.rb:220:in transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:1044:in ddl_transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:997:in execute_migration_in_transacti on' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:959:in block in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:955:in each' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:955:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:823:in up' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:801:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/tasks/database_tasks.rb:137:in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/railties/databases.rake:44:in block (2 levels) in
<top (required)>’
Addressable::URI::InvalidURIError: Invalid port number: “crm”
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:1283:in port=' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:803:in block in initialize’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:2248:in call' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:2248:in defer_validation’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:795:in initialize' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:138:in new’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/addressable-2.3.8/lib/addressable/uri.rb:138:in parse' /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/url_sanitizer.rb:10:in initialize’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:27:in new' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:27:in block in process_proj
ects_with_wrong_url’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in block in each' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in each’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/result.rb:51:in each' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:25:in process_projects_with
wrong_url’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:16:in block in up' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:63:in block (2 levels) in i
n_transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb
:211:in transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/transactions.rb:220:in transaction’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:62:in block in in_transacti on' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in block in say_with_time’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in say_with_time' /opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:61:in in_transaction’
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20160302152808_remove_wrong_import_url_from_projects.rb:16:in up' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:611:in exec_migration’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:592:in block (2 levels) in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:591:in block in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:292
:in with_connection' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:590:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:768:in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:998:in block in execute_migration_in

transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:1044:in block in ddl_transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb :213:in block in transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/transaction.rb:184:in
within_new_transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb :213:in transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/transactions.rb:220:in transaction' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:1044:in ddl_transaction’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:997:in execute_migration_in_transacti on' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:959:in block in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:955:in each' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:955:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:823:in up' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/migration.rb:801:in migrate’
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/tasks/database_tasks.rb:137:in migrate' /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activerecord-4.2.6/lib/active_record/railties/databases.rake:44:in block (2 levels) in
<top (required)>’
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

Bloody dumb workaround not to be used in production :slight_smile:

gitlab-rake db:migrate:status --trace

find first task which is down and

gitlab-rake gitlab:db:mark_migration_complete[20160302152808]

and then

gitlab-ctl reconfigure

doesn’t fail

Meanwhile I did some googling and found this https://gitlab.com/gitlab-org/gitlab-ee/issues/3312 But in our instance link to every repo looks like: git@gitlab.mycompany.pl:somegroup/project.git This renders upgrade to 8.x impossible?