We want to migrate our code reviews to Gitlab. Here’s our current work flow:
- developer creates feature on a feature branch
- submits code to Phabricator to be reviewed
- on accept, the branch is pushed
- testers test the branch and approve it
- developer creates merge request and branch is merged into development
I read this article about how a typical gitlab flow works and I was wondering how we could include our testers in it. We came up with this solution:
- developer creates feature on a feature branch
- when the feature is done, the branch is pushed
- testers test the branch and approve it
- developer creates merge request and the code is reviewed.
The problem is that in case the code review fails and needs to be modified, the branch needs to be tested again before going back to review.
Is this an ok solution and I’m just overthinking it? What do you guys think?